Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsx: Reimplement texture border colors #16169

Merged
merged 7 commits into from
Oct 3, 2024
Merged

Conversation

kd-11
Copy link
Contributor

@kd-11 kd-11 commented Oct 3, 2024

Vulkan and OGL handle the border texels differently. In OpenGL where we first added them, the swizzle defined in the texture view reorders the elements before returning the value to the shaders. In Vulkan they are treated as texel replacements and skip the remapping steps.

Fixes #15422

rpcs3/Emu/RSX/color_utils.h Show resolved Hide resolved
rpcs3/Emu/RSX/color_utils.h Outdated Show resolved Hide resolved
rpcs3/Emu/RSX/color_utils.h Show resolved Hide resolved
@Megamouse Megamouse added the RSX label Oct 3, 2024
@kd-11 kd-11 merged commit e9bc992 into RPCS3:master Oct 3, 2024
5 of 8 checks passed
@RPCS3 RPCS3 deleted a comment from Satumariko Oct 5, 2024
@RPCS3 RPCS3 locked and limited conversation to collaborators Oct 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Regression] Uncharted: Drakes Fortune [BCES00065]: Water does not render correctly (#13901)
2 participants