Add base64Encode handlebars helper #4925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwisniew
approved these changes
Sep 24, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
This is intended to pair with the browser atob function so no base64Decode is provided, but should be equivalent to the mtscript base64Encode if data has already been encoded into the token's properties.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
closes #4924
Description of the Change
This adds a handlebars helper called
base64Encodethat uses the same encoder as the macro, which happens to use the right parameters to pair with the browser'satobfunction.Possible Drawbacks
I have not included a
base64Decodefunction because I could not think of what it would be useful for, it's fallible if given the wrong input and would be hard to handle errors in handlebars so people should do it in javascript.Documentation Notes
base64Encode
Turns the textual form of the value into a base64-encoded string. For example:
<script type="application/json;base64" id="jsonProperty"> {{ base64Encode properties[0].value }} </script> <script type="application/javascript"> const jsonProperty = JSON.parse(atob(document.getElementById("jsonProperty").innerText)); </script>Release Notes
{{base64Encode value}}and then decode in javascript withatob(document.getElementById(...).innerText).This change is