Fix map dragging state management in DefaultTool #5033
+33
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a drag is completed, the drag state is completely cleared so it can't be reused again later, even accidentally. This ensures that we aren't affected by the strange case of a right-button drag event comming in before the right-button press event.
kwvanderlinde
force-pushed
the
bugfix/5032-jumpy-map-drag
branch
from
661c2dc
to
85cfb29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Fixes #5032
Description of the Change
The issue was caused by the combination of
DefaultToolkeeping around previous drag positions, and the surprising ability formouseDragged()events to start before correspondingmousePressed()events if other mouse buttons are already presssed. This PR fixes the problem by clearing drag state whenever a drag completes, and double-checking that a map drag has actually begun when inmouseDragged().Possible Drawbacks
None
Documentation Notes
N/A
Release Notes
This change is