Fix logo image SHA-256 and size in test #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test failure introduced in 556f7be. The commit in question has changed the logo image and since the SHA-256 and size of the image is verified in the integration test, the test subsequently fails. A better way to solve this would be if we'd have a way to properly parameterise the main functionality instead of expecting users to change source files. This could probably involve turning the project into a proper Godot plugin, which I outlined in #2. For now however, I don't have a lot of time to allocate to dig into Godot plugins, so I'm simply fixing the SHA-256 and size. Signed-off-by: aszlig <[email protected]>
|
@RPicster: Hooray :-)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test failure introduced in 556f7be.
The commit in question has changed the logo image and since the SHA-256 and size of the image is verified in the integration test, the test subsequently fails.
A better way to solve this would be if we'd have a way to properly parameterise the main functionality instead of expecting users to change source files. This could probably involve turning the project into a proper Godot plugin, which I outlined in #2.
For now however, I don't have a lot of time to allocate to dig into Godot plugins, so I'm simply fixing the SHA-256 and size.