Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New bridge: FilterMore #4015

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

New bridge: FilterMore #4015

wants to merge 12 commits into from

Conversation

boyska
Copy link

@boyska boyska commented Mar 16, 2024

this bridge allows the user to have a filtered version of a feed.

it is quite advanced: offers regexp filtering, sorting, limiting...

I used it when I wanted to follow a websites including events. They had no way to filter based on city, but they were specifying that in the title, so I could use this bridge to get what I wanted.

The has_media field is particularly useful for podcasts: sometimes I want to just play the first audio in a feed. With this, I can :

  • filter has_media
  • limit=1
    which gives me exactly what I wanted.

@boyska boyska marked this pull request as ready for review March 16, 2024 22:12
Copy link

github-actions bot commented Mar 16, 2024

Pull request artifacts

Bridge Context Status
FilterMore 1 untitled (pr) Bridge returned error 404! (19832)
Type: HttpException
Message: https://example.com/feed/ resulted in 404 Not Found <!doctype html>

last change: Friday 2024-04-19 10:54:12

@dvikan
Copy link
Contributor

dvikan commented Mar 31, 2024

we already have FilterBridge which i hope you have taken a look at.

need more time and community feedback on whether to include this bridge.

return $url;
}

public function collectData()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move this method up up up so that it is the first method in class.

code is to be read chronologically just like reading a book.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done! let me know if you like it now

@boyska
Copy link
Author

boyska commented Mar 31, 2024

we already have FilterBridge which i hope you have taken a look at.

yes, I know that and have used it. I think that FilterMore is far more advanced, but I can see how having duplicates is not great for the project.

@dvikan
Copy link
Contributor

dvikan commented Mar 31, 2024

yes FilterMore I like the name and its features. also FilterLess is a good name :D

if okay i would like wait for community feedback from other users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants