fix:Regarding the style issue of selecting subscription types using the Tab and arrow keys #525
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When switching subscription types, the right side may briefly show the content of the previous type before displaying the current type's content after the data request is completed.
…he Tab and arrow keys When a subscription type is selected with the mouse and then switched using the tab key or arrow keys, the background color of the subscription type does not change correctly, always remaining dark for the initially clicked type. I noticed in the code that the style includes focus-visible:bg-zinc-500/30 focus-visible:!outline-none which suggests that the intended behavior is for the background color to change based on the currently focused subscription type when using the tab key or arrow keys. However, the focus-visible style may not be applied correctly due to keyboard event listeners in the code. To address this, I introduced a variable to track whether the switch is made via the tab key or arrow keys.
|
@cuikaipeng is attempting to deploy a commit to the RSS3 Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a subscription type is selected with the mouse and then switched using the tab key or arrow keys, the background color of the subscription type does not change correctly, always remaining dark for the initially clicked type.
I noticed in the code that the style includes
which suggests that the intended behavior is for the background color to change based on the currently focused subscription type when using the tab key or arrow keys.
However, the focus-visible style may not be applied correctly due to keyboard event listeners in the code.
To address this, I introduced a variable to track whether the switch is made via the tab key or arrow keys.