Merge pull request #1876 from zhengbw0324/master

FIX: fix the bug in negative sampling.
RUCAIBox · Sep 23, 2023 · 4d7822f · 4d7822f
2 parents 96eb311 + dbaeb5f
commit 4d7822f
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/recbole/data/dataloader/abstract_dataloader.py b/recbole/data/dataloader/abstract_dataloader.py
@@ -137,7 +137,7 @@ def _set_neg_sample_args(self, config, dataset, dl_format, neg_sample_args):
         self.times = 1
         if (
             self.neg_sample_args["distribution"] == "uniform"
-            or "popularity"
+            or self.neg_sample_args["distribution"] == "popularity"
             and self.neg_sample_args["sample_num"] != "none"
         ):
             self.neg_sample_num = self.neg_sample_args["sample_num"]