-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add fissa model #1310
base: master
Are you sure you want to change the base?
Conversation
@Wicknight Thanks for your kind advice. I have taken them into account and committed to a new version. Plz, check it. |
@Wicknight Thanks for your advice again.
|
@Tokkiu Thank you for your support and help to RecBole! I'll check it soon. |
@Wicknight Thanks for your kind comments. I fixed them according to your advice. It makes sense! |
@Wicknight Thank you for your comments. Is there anything need to be improved? |
Thank you for your support. I am testing on other datasets and waiting for the results. I will inform you as soon as I finish the test. |
@Tokkiu During the test, I had a little doubt about the candidate items in line 116 and line 117. All items are used as candidate items in the code here. This increases the burden on the GPU and it seems to be inconsistent with the original intention of the paper. Is there any alternative in your opinion? |
@Wicknight Thanks for your concern. |
@Tokkiu I think this is a good suggestion. Thank you for your help again! I have conducted certain tests, but it seems that I can not reproduce the results reported in the paper. Therefore, I would like to ask whether you have successfully reproduced the results of the paper? |
Yes, I have same conclusion. From my test results. The performance of FISSA is comparable with SASRec. But it can't outperform SASRec consistently as mentioned in paper. |
Could you tell me how many datasets in the paper have you used for testing?Does this inconsistency occur on all datasets? |
I mainly test datasets in MovieLens. It shows similar performance on ml-1m and ml-10m with comparable performance on ml-100k. |
So you didn't test on the five datasets used in the paper? |
Yes, did you test on them?How about performance gap? |
First of all, thank you for your PR and efforts to RecBole! I didn't test on all datasets, but the inconsistency occurred on several datasets. So If you want to launch this model, you must be able to reproduce the results of the paper. Thank you again for your contribution! I also hope you can continue to discuss the reasons for this inconsistency with me. |
Nice suggestion! I am executing experiments on datasets mainly used in the paper. And I think the inconsistency may come from hyperparameter settings, e.g., max sequence length, dropout ratio, and negative sampling. |
Add FISSA model to recbole.
https://doi.org/10.1145/3383313.3412247