Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐛 BUG] Fix bugs when collecting results from mp.spawn in multi-GPU training #1875

Merged

Conversation

ChenglongMa
Copy link
Contributor

@ChenglongMa ChenglongMa commented Sep 22, 2023

Bug description

We are unable to collect results directly from mp.spawn, e.g.,

res = mp.spawn(
run_recboles,
args=(
args.model,
args.dataset,
config_file_list,
args.ip,
args.port,
args.world_size,
args.nproc,
args.group_offset,
),
nprocs=args.nproc,
)

torch.multiprocessing.Queue can be applied for this purpose.

Changelog in this PR

  1. Fixd result collection bug when using mp.spawn;
  2. Updated documents of distributed training;
  3. Fix bugs in significance_test.py

@Sherry-XLL Sherry-XLL requested a review from Ethan-TZ October 7, 2023 03:06
@Ethan-TZ Ethan-TZ self-assigned this Oct 8, 2023
@Ethan-TZ Ethan-TZ merged commit 22d8ad8 into RUCAIBox:master Oct 14, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants