fix: resolve inconsistent sample rates and improve Train tab layout #2234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses two issues on the Train tab:
1. **Inconsistent Target Sample Rates:**
- Resolved an issue where switching versions led to inconsistent Target sample rates. Additionally, it fixes a missing v2 - 40k configuration file. Despite v2 having a 40k pretrained model, configurations were mismatched:
- assets/pretrained (32k, 40k, 48k)
- assets/pretrained_v2 (32k, 40k, 48k)
- configs/v1 (32k, 40k, 48k)
- configs/v2 (32k, 48k)
- Tests showed that a 40k - v2 setting generated an incorrect 40k - v1 config file. The default settings have been updated to use 48k - v2 to align the sample rates correctly.
Now:
- v1 will consistently show 32k, 40k, and 48k
- v2 will consistently show 32k and 48k
**Note:** Ensures that selecting the 40k option for v2 no longer results in an incorrect configuration file, aligning the sample rates across both versions.
2. **Repositioned 'Version' Field:**
- Moved the 'Version' field to appear before the 'Target sample rate' field on the Train tab. This improves the logical flow and user experience by ensuring that the 'Version' selection is made before choosing the 'Target sample rate'.
Changes:
- Updated layout on the Train tab to reposition the 'Version' field.
- Ensured that field updates are reflected correctly.
**Note:** Aligns with a more intuitive user workflow by ensuring users select the version first before setting the target sample rate. No functional changes to the data processing were made.
Noticed that the code was making an exception with the line: `if version19 == "v1" or sr2 == "40k":` This approach isn't ideal, as it causes v2 - 40k to fallback to v1 - 40k. While this fix re-adds the necessary code, a better long-term solution might be to copy the v1 - 40k config into the v2 config folder to avoid such exceptions in the future.
fumiama
added a commit
to fumiama/Retrieval-based-Voice-Conversion-WebUI
that referenced
this pull request
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
PR type
Description
This commit addresses two issues on the Train tab:
Inconsistent Target Sample Rates:
Now:
Note: Ensures that selecting the 40k option for v2 no longer results in an incorrect configuration file.
Repositioned 'Version' Field:
Changes:
Note: No functional changes to the data processing were made.