Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collapse all tree control (#203) #204

Merged
merged 3 commits into from
May 20, 2020

Conversation

gregveres
Copy link
Contributor

Add collapse all and expand all to the tree control

I have added two icons to the tree control icon area. The first collapses
all the directories in the tree except the root directory and the other
expands all the directories in the tree.

This makes it much easier to find a test file to work on.
I also put the icons on the right side because that is where the
"show failing tests only" icon appears and it seemed that they were
similar types of operations. Then I realized that the collapse / expand
don't make sense when the show failing test only icon is toggled
so in that case I hide the icons.

And then because the icons vanish and appear, I rearranged their
position to what I thought made more sense.
Refresh: is always present and always in a fixed location on the right
The most important button is show only failed so it shows up on the
left as the first in the list when there are failed tests.
Then the collapse/expand
Then the coverage (which I think is the least likely to be used) and
therefore in the "hardest spot to hit"

#203

gregveres and others added 3 commits May 15, 2020 10:51
sync with official fork v1.7.0
bring official up to date with latest changes
I have added two icons to the tree control icon area. The first collapses
all the directories in the tree except the root directory and the other
expands all the directories in the tree.

This makes it much easier to find a test file to work on.
I also put the icons on the right side because that is where the
"show failing tests only" icon appears and it seemed that they were
similar types of operations. Then I realized that the collapse / expand
don't make sense when the show failing test only icon is toggled
so in that case I hide the icons.

And then because the icons vanish and appear, I rearranged their
position to what I thought made more sense.
Refresh: is always present and always in a fixed location on the right
The most important button is show only failed so it shows up on the
left as the first in the list when there are failed tests.
Then the collapse/expand
Then the coverage (which I think is the least likely to be used) and
therefore in the "hardest spot to hit"
Raathigesh#203
@gregveres
Copy link
Contributor Author

@Raathigesh I think I am done for a while. I think I am out of ideas on how to make Majestic better. With all of these changes, I am very happy with the workflow. I was using the orta.vscode-jest extension inside vscode to run the tests, but I was finding the workflow too clunky and it kept leaving outdated statuses in my editor and I couldn't tell when it was running to regenerate snapshots etc. So I came back to Majestic and with these workflow improvements, it is quite brilliant. I have been maintaining my own version because I want the collapsable tests, but I have worked out a branching scheme that allows me to easily produce a PR for your fork for all the new changes. (as you can tell by all the new PRs over the last couple of days).

Anyway, thank you for creating the tool and contributing to the community!

BTW, now that I have started to learn React more through working on this project, I find Vue way easier to use and understand. If you create a new project, you might want to give it a try. Vue 3 (with some much needed improvements for typescript) is in Beta now and it is the version you would want to learn. If you do, don't bother trying to user Vuex with typescript, it is a nightmare, well, it's not that much of a nightmare if you don't care about unit tests.

@Raathigesh
Copy link
Owner

@gregveres I'm glad you are finding the tool useful. I'm also really glad for all your contributions. People like you make project like these going. Thank you for all your effort.

I heard good things about Vue 3 and the composition API. I'll check it out soon :)

@Raathigesh Raathigesh merged commit ac7dbe6 into Raathigesh:master May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants