Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new pyuvdata analytic short dipole beam in our polarized source test. #268

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

bhazelton
Copy link
Member

@bhazelton bhazelton commented Oct 30, 2024

Description

Replaces the ad hoc analytic short dipole used in our testing of polarized sources with the pyuvdata analytic short dipole beam.

This requires bumping the minimum pyuvdata version to v3.1.0.

I also bumped the minimum lunarsky version to 0.2.5 for compatibility with astropy 6.0

Motivation and Context

Checklists:

Other Change Checklist

  • I have read the contribution guide.
  • My code follows the code style of this project.
  • Any new or updated docstrings use the numpy docstring format.
  • I have updated the tutorial to highlight my new feature (if appropriate).
  • I have added tests to cover any changes.
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible).
  • I have updated the CHANGELOG if appropriate.

this requires pyuvdata>=3.1.0
Also update lunarsky dependency to require 0.2.5 to be compatibly with astropy 6.0
@bhazelton bhazelton added the technical debt Code cleanup to meet our own standards label Oct 30, 2024
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (eb75e59) to head (2f9fecc).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #268   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines         2121      2120    -1     
  Branches       543       543           
=========================================
- Hits          2121      2120    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical debt Code cleanup to meet our own standards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant