Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to prevent errors with pyuvdata 3.0 #432

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Conversation

bhazelton
Copy link
Member

Description

Motivation and Context

Fixes a few things that will error in the future.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Reference simulation update or replacement
  • Documentation change (documentation changes only)
  • Version change
  • Build or continuous integration change

Checklist:

For all pull requests:

Bug fix checklist:

  • My fix includes a new test that breaks as a result of the bug (if possible).
  • All new and existing tests pass.
  • I have checked that I reproduce the reference simulations or if there are differences they are explained below (if appropriate). If there are changes that are correct, I will update the reference simulation files after this PR is merged.
  • I have checked (e.g., using the benchmarking tools) that this change does not significantly increase typical runtimes. If it does, I have included a justification in the comments on this PR.
  • I have updated the CHANGELOG.

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (d5e97cb) 99.49% compared to head (3390814) 99.49%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #432   +/-   ##
=======================================
  Coverage   99.49%   99.49%           
=======================================
  Files          12       12           
  Lines        2198     2199    +1     
=======================================
+ Hits         2187     2188    +1     
  Misses         11       11           
Files Changed Coverage Δ
pyuvsim/simsetup.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

mkolopanis
mkolopanis previously approved these changes Sep 7, 2023
Copy link
Member

@mkolopanis mkolopanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@mkolopanis
Copy link
Member

weird that herasim failed on push but not PR

@mkolopanis mkolopanis merged commit 46a95f1 into main Sep 7, 2023
27 checks passed
@mkolopanis mkolopanis deleted the pyuvdata_future_proof branch September 7, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants