Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More test coverage and other cleanup #450

Merged
merged 9 commits into from
Feb 29, 2024
Merged

More test coverage and other cleanup #450

merged 9 commits into from
Feb 29, 2024

Conversation

bhazelton
Copy link
Member

@bhazelton bhazelton commented Feb 26, 2024

Description

I thought I'd added coverage for all the easy to cover lines in #449 but after it was merged I found that there were still some lines missing in simsetup.py. This PR does several things (sorry!):

  • Adds coverage for some missing lines
  • Updates the badges on the readme and other things throughout the repo to point to the main branch rather than master.
  • Adds some text about pyradiosky in the tutorial and a link to the pyradiosky docs.
  • Changes the RTD sphinx theme to match the one we use on other RASG repos.
  • Runs one CI job on pip rather than conda. This has exposed some weirdnesses in the past on pyradiosky, so I wanted to do it here. I used the min_deps run because it's hard to get mpi4py to install via pip.
  • Explicitly test against both Open MPI and MPICH implementations to ensure they both work and to avoid picking up the Intel MPI implementation (impi), which was breaking our tests.

Motivation and Context

closes #319

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Reference simulation update or replacement
  • Documentation change (documentation changes only)
  • Version change
  • Build or continuous integration change

Checklist:

For all pull requests:

Build or continuous integration change checklist:

  • If required or optional dependencies have changed (including version numbers), I have updated the readme to reflect this.
  • If this is a new CI setup, I have added the associated badge to the readme and to references/make_index.py (if appropriate).

Documentation change checklist:

  • Any updated docstrings use the numpy docstring format.
  • If this is a significant change to the readme or other docs, I have checked that they are rendered properly on ReadTheDocs. (you may need help to get this branch to build on RTD, just ask!)

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.86%. Comparing base (80b9f6a) to head (7d989d8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #450      +/-   ##
==========================================
+ Coverage   99.68%   99.86%   +0.17%     
==========================================
  Files          12       12              
  Lines        2235     2235              
==========================================
+ Hits         2228     2232       +4     
+ Misses          7        3       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bhazelton bhazelton changed the title More test coverage More test coverage and other cleanup Feb 26, 2024
@bhazelton bhazelton added this to the New release milestone Feb 26, 2024
Copy link
Member

@mkolopanis mkolopanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question!

.github/workflows/testsuite.yaml Outdated Show resolved Hide resolved
@bhazelton bhazelton mentioned this pull request Feb 29, 2024
Copy link
Member

@mkolopanis mkolopanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah this works for me thanks!

@mkolopanis mkolopanis merged commit 998050d into main Feb 29, 2024
33 checks passed
@mkolopanis mkolopanis deleted the test_coverage branch February 29, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check and document simulations for source spectra
2 participants