-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More test coverage and other cleanup #450
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #450 +/- ##
==========================================
+ Coverage 99.68% 99.86% +0.17%
==========================================
Files 12 12
Lines 2235 2235
==========================================
+ Hits 2228 2232 +4
+ Misses 7 3 -4 ☔ View full report in Codecov by Sentry. |
cf92c3e
to
9203d59
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one question!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah this works for me thanks!
Description
I thought I'd added coverage for all the easy to cover lines in #449 but after it was merged I found that there were still some lines missing in simsetup.py. This PR does several things (sorry!):
impi
), which was breaking our tests.Motivation and Context
closes #319
Types of changes
Checklist:
For all pull requests:
Build or continuous integration change checklist:
Documentation change checklist: