Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more units in Weight Calculator #1086

Merged
merged 4 commits into from
Jun 3, 2024

Conversation

DiwareNamrata23
Copy link
Contributor

@DiwareNamrata23 DiwareNamrata23 commented Jun 2, 2024

Fixes Issue🛠️

Closes #678

Description👨‍💻

In Weight Calculator, there are only two units available, I had added 8 more units.

Type of change📄

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How this has been tested✅

Checklist✅

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added demonstration in the form of GIF/video file
  • I am an Open Source Contributor

Screenshots/GIF📷

Screenshot 2024-06-02 at 9 08 34 AM

[Feature] Add more units in Weight Calculator
Copy link

netlify bot commented Jun 2, 2024

Deploy Preview for calcdiverse ready!

Name Link
🔨 Latest commit 7bcc192
🔍 Latest deploy log https://app.netlify.com/sites/calcdiverse/deploys/665e0979b15bb40008bfea81
😎 Deploy Preview https://deploy-preview-1086--calcdiverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @DiwareNamrata23, Welcome to the project CalcDiverse! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

@DiwareNamrata23 DiwareNamrata23 changed the title Feature-678 Feature-678 Add more units in Weight Calculator Jun 2, 2024
@DiwareNamrata23 DiwareNamrata23 changed the title Feature-678 Add more units in Weight Calculator [Feature]678 Add more units in Weight Calculator Jun 2, 2024
@Rakesh9100 Rakesh9100 changed the title [Feature]678 Add more units in Weight Calculator Added more units in Weight Calculator Jun 3, 2024
@Rakesh9100 Rakesh9100 merged commit 69fbd1f into Rakesh9100:main Jun 3, 2024
4 checks passed
@Rakesh9100
Copy link
Owner

Congrats on getting your PR merged to the repo under GSSOC 2k24 🥳🎉 @DiwareNamrata23

@Rakesh9100 Rakesh9100 added Completed 🥳 PR successfully merged and issue resolved on completion gssoc GSSoC 2k24 Open Source Program level2 GSSoC2k24 Level-2 Task -- 25 Points labels Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completed 🥳 PR successfully merged and issue resolved on completion gssoc GSSoC 2k24 Open Source Program level2 GSSoC2k24 Level-2 Task -- 25 Points
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add more units in Weight Calculator
2 participants