Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented smooth scrolling #1129

Closed
wants to merge 1 commit into from
Closed

Conversation

Mandar007007
Copy link

@Mandar007007 Mandar007007 commented Jun 3, 2024

Fixes Issue🛠️

Closes #646

Description👨‍💻

Now the webpage scrolling is smoother due to locomotive JS library.

Type of change📄

  • New feature (non-breaking change which adds functionality)

How this has been tested✅

Tested locally.

Checklist✅

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added demonstration in the form of GIF/video file
  • I am an Open Source Contributor

Screenshots/GIF📷

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Mandar007007, Welcome to the project CalcDiverse! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

Copy link

netlify bot commented Jun 3, 2024

Deploy Preview for calcdiverse ready!

Name Link
🔨 Latest commit a110533
🔍 Latest deploy log https://app.netlify.com/sites/calcdiverse/deploys/665d80b731382700084992a5
😎 Deploy Preview https://deploy-preview-1129--calcdiverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Rakesh9100
Copy link
Owner

Pls work on these @Mandar007007

  1. Mention the issue number for which you have created this PR.
  2. Navbar should be sticky and fixed as it was before.
  3. Scrollbar track and thumb should be visible as it was before.

@Rakesh9100 Rakesh9100 added the question 🤔 Further information is requested label Jun 4, 2024
@Rakesh9100 Rakesh9100 closed this Jun 9, 2024
@Rakesh9100 Rakesh9100 changed the title smooth scrolling done Implemented smooth scrolling Jun 9, 2024
@Rakesh9100 Rakesh9100 removed the question 🤔 Further information is requested label Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Implement smooth scrolling using locomotive js
2 participants