Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced Palindrome Calculator UI #1149

Merged
merged 11 commits into from
Jun 5, 2024
Merged

Enhanced Palindrome Calculator UI #1149

merged 11 commits into from
Jun 5, 2024

Conversation

diyaaa19
Copy link
Contributor

@diyaaa19 diyaaa19 commented Jun 3, 2024

Fixes Issue🛠️

Closes #659

Description👨‍💻

Palindrome calculator UI enhanced along with calculate again button, and all items centrally aligned along with changes in form and background.

Type of change📄

  • New feature (non-breaking change which adds functionality)

How this has been tested✅

Tested locally.

Checklist✅

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added demonstration in the form of GIF/video file
  • I am an Open Source Contributor

Screenshots/GIF📷

image

Copy link

netlify bot commented Jun 3, 2024

Deploy Preview for calcdiverse ready!

Name Link
🔨 Latest commit 12ff183
🔍 Latest deploy log https://app.netlify.com/sites/calcdiverse/deploys/66606b22fe6cc10008055dff
😎 Deploy Preview https://deploy-preview-1149--calcdiverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @diyaaa19, Welcome to the project CalcDiverse! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

@diyaaa19
Copy link
Contributor Author

diyaaa19 commented Jun 3, 2024

@Rakesh9100 Please review and merge, completed all assigned issues

@Rakesh9100
Copy link
Owner

Pls attach the screenshots of your work @diyaaa19

@Rakesh9100 Rakesh9100 changed the title Palindrome calculator UI enhanced Enhanced Palindrome Calculator UI Jun 4, 2024
@Rakesh9100 Rakesh9100 added the question 🤔 Further information is requested label Jun 4, 2024
@diyaaa19
Copy link
Contributor Author

diyaaa19 commented Jun 4, 2024

@Rakesh9100 added the screenshots

@Rakesh9100
Copy link
Owner

When clicking on Calculate after entering an input, the result should show below only as it was before, it should not redirect to Calculate Again @diyaaa19

@diyaaa19
Copy link
Contributor Author

diyaaa19 commented Jun 4, 2024

@Rakesh9100 made the required changes, please review, thanks

@Rakesh9100
Copy link
Owner

If an issue is open to enhance the UI, then pls make something good. You just did center some text and just changed some color @diyaaa19

@diyaaa19
Copy link
Contributor Author

diyaaa19 commented Jun 4, 2024 via email

@Rakesh9100
Copy link
Owner

https://calcdiverse.netlify.app/calculators/color-code-calculator/

You can take the reference of this and try to style a bit more by using some good background or gradient background, and also give effects to the text @diyaaa19

@diyaaa19
Copy link
Contributor Author

diyaaa19 commented Jun 5, 2024

@Rakesh9100 Let me know if any more changes are required

@Rakesh9100 Rakesh9100 merged commit 09ed858 into Rakesh9100:main Jun 5, 2024
4 checks passed
Copy link

github-actions bot commented Jun 5, 2024

Congrats, Your pull request has been successfully merged 🥳🎉 Thank you for your contribution to my project 🚀 Keep Contributing!! ✨ @diyaaa19

@Rakesh9100 Rakesh9100 added Completed 🥳 PR successfully merged and issue resolved on completion gssoc GSSoC 2k24 Open Source Program and removed question 🤔 Further information is requested labels Jun 5, 2024
@Rakesh9100 Rakesh9100 added the level2 GSSoC2k24 Level-2 Task -- 25 Points label Jun 5, 2024
@diyaaa19 diyaaa19 deleted the pal branch June 7, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completed 🥳 PR successfully merged and issue resolved on completion gssoc GSSoC 2k24 Open Source Program level2 GSSoC2k24 Level-2 Task -- 25 Points
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Style] Enhance Palindrome Calculator UI
2 participants