Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Remove Subject option in Grade Calculator #1169

Closed
wants to merge 0 commits into from

Conversation

dadigavasavipriya
Copy link
Contributor

@dadigavasavipriya dadigavasavipriya commented Jun 4, 2024

Fixes Issue🛠️

Closes #1002

Description👨‍💻

Added Remove Subject option in Absolute Grade Calculator and changed marks input format

Type of change📄

  • New feature (non-breaking change which adds functionality)

How this has been tested✅

I have tested in my own local host.

Checklist✅

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added demonstration in the form of GIF/video file
  • I am an Open Source Contributor

Screenshots/GIF📷

bandicam.2024-06-06.16-01-15-769.mp4

@Rakesh9100 please review the changes, and please review this pull request. Please let me know any changes required. Thank you, once again, for assigning me this issue

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dadigavasavipriya, Welcome to the project CalcDiverse! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

Copy link

netlify bot commented Jun 4, 2024

Deploy Preview for calcdiverse ready!

Name Link
🔨 Latest commit b02421f
🔍 Latest deploy log https://app.netlify.com/sites/calcdiverse/deploys/665f07942ba548000868402a
😎 Deploy Preview https://deploy-preview-1169--calcdiverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dadigavasavipriya
Copy link
Contributor Author

I noticed there are conflicts in the files Calculators/Grade-Calculator/script.js and Calculators/Grade-Calculator/style.css that need to be resolved. Can I address this and proceed with creating a new pull request.

@Rakesh9100 Rakesh9100 changed the title Add Remove Button for Subject Fields and Update Marks Input Format Added Remove Subject option in Grade Calculator Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add Remove Subject option in Grade Calculator
1 participant