Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Wedding Budget Calculator #1501

Closed
wants to merge 12 commits into from

Conversation

mahek0620
Copy link
Contributor

@mahek0620 mahek0620 commented Jun 29, 2024

Fixes Issue🛠️

Closes #1160

Description👨‍💻

The provided code creates a "Wedding Budget Calculator" web application that allows users to input various wedding-related expenses (venue, catering, decor, photography, entertainment, attire, and other costs) and calculate the total budget. It also provides a breakdown of each cost as a percentage of the total budget. The HTML code sets up the structure and input fields, the CSS styles the page, and the JavaScript handles the calculation logic and error handling for the inputs. Additionally, there's a reset functionality to clear all inputs and results.
Calculates total cost of wedding
Additional cost categories.
Input validation with specific error messages.
A reset button to clear all fields.
Percentage of total budget for each category.

Type of Change📄

  • New feature (non-breaking change which adds functionality)

Checklist✅

  • I am an Open Source contributor
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented on my code, particularly in hard-to-understand areas

Screenshots/GIF📷

image

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mahek0620, Welcome to the project CalcDiverse! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

Copy link

netlify bot commented Jun 29, 2024

Deploy Preview for calcdiverse ready!

Name Link
🔨 Latest commit 516bb5d
🔍 Latest deploy log https://app.netlify.com/sites/calcdiverse/deploys/6690e85dfb6eaf0008c2d7f0
😎 Deploy Preview https://deploy-preview-1501--calcdiverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mahek0620
Copy link
Contributor Author

@Rakesh9100 kindly review this

@Rakesh9100 Rakesh9100 changed the title Wedding budget Added Wedding Budget Calculator Jul 1, 2024
@Rakesh9100
Copy link
Owner

Page is not fully scrollable due to which heading is not visible, pls fix!
Enhance and style the UI nicely @mahek0620

@Rakesh9100 Rakesh9100 added the question 🤔 Further information is requested label Jul 2, 2024
@Rakesh9100
Copy link
Owner

Any update or should I close the PR @mahek0620

@mahek0620
Copy link
Contributor Author

@Rakesh9100 file has been modified

@Rakesh9100
Copy link
Owner

You have not modified anything, just silly changes you are doing! Check the comment I have added above and work.

Check the Deploy preview and work accordingly @mahek0620

@mahek0620
Copy link
Contributor Author

Screenshot 2024-07-08 123334
Screenshot 2024-07-08 123351
Screenshot 2024-07-08 123632
Screenshot 2024-07-08 123649

@mahek0620
Copy link
Contributor Author

@Rakesh9100 The code has been modified according to your review

@Rakesh9100
Copy link
Owner

Neither UI is enhanced nor NaN value is handled, and you are opening too many issues without properly fixing this PR @mahek0620

@mahek0620
Copy link
Contributor Author

I have attached the screenshots it's fully scrollable

@bharat-c27
Copy link
Contributor

bharat-c27 commented Jul 12, 2024

Hello @Rakesh9100 , I understood the issue and I can enhance the UI with proper validation of the input.

Can you assign this issue to me ?

@Rakesh9100 Rakesh9100 removed the question 🤔 Further information is requested label Jul 16, 2024
@Rakesh9100 Rakesh9100 closed this Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add Wedding Budget Calculator
3 participants