Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Unique Prime Number Calculator #1589

Merged
merged 9 commits into from
Jul 14, 2024

Conversation

bharat-c27
Copy link
Contributor

@bharat-c27 bharat-c27 commented Jul 9, 2024

Fixes Issue🛠️

Closes #1095

Description👨‍💻

The Unique Prime Number Calculator is a web-based tool designed to identify and work with unique prime numbers. A unique prime number is a prime number that remains prime even after removing any single digit from it.

Features :

Prime Check: Enter a number to determine if it is a unique prime. The calculator checks if the number is prime and if all resulting numbers from removing any single digit are also prime.

Range Finder: Input a range of numbers to find all unique prime numbers within that range. The tool will display all unique prime numbers that satisfy the conditions within the specified range.

Type of Change📄

  • New feature (non-breaking change which adds functionality)

Checklist✅

  • I am an Open Source contributor
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project

Screenshots/GIF📷

Screenshot 2024-07-09 230841

Copy link

netlify bot commented Jul 9, 2024

Deploy Preview for calcdiverse ready!

Name Link
🔨 Latest commit d3d11fb
🔍 Latest deploy log https://app.netlify.com/sites/calcdiverse/deploys/6693b764151e9400088965b1
😎 Deploy Preview https://deploy-preview-1589--calcdiverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bharat-c27, Welcome to the project CalcDiverse! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

@Nihal4777
Copy link

@bharat-c27 Please add empty field validations.
image

@bharat-c27
Copy link
Contributor Author

Sure @Nihal4777, I will add the validation.

@bharat-c27
Copy link
Contributor Author

Hello @Nihal4777, I have added the validation for both, finding unqiue number and for finding range also.
I am done with the validation, can you please review and assign me the labels

Thank you!!!

@Rakesh9100
Copy link
Owner

Pls work on these @bharat-c27

1. Add 1-2 lines proven explanation below the text, for example 23 is a unique prime number. of why and how a number is a unique number and same for non-unique number.

2. If I find the unique numbers in range 1 to 10000000, then the page is not fully scrollable.

@Rakesh9100 Rakesh9100 added the question 🤔 Further information is requested label Jul 12, 2024
@bharat-c27
Copy link
Contributor Author

bharat-c27 commented Jul 12, 2024

@Rakesh9100 I have added the explanation and also the UI is now fully scrollable.
Please review it and assign me.

Also, I have completed the issue no #1317 so can you please assign me so that I can raise the PR

Thank you !!

@Rakesh9100
Copy link
Owner

Make the UI responsive for the small screens @bharat-c27

@bharat-c27
Copy link
Contributor Author

@Rakesh9100 can you please provide a photo or a video, for which screen size the calculator is not responsive ?

In the below video the UI is looking responsive

Screen.Recording.2024-07-13.005722.mp4

@Rakesh9100
Copy link
Owner

Pls check for the screen size less than 450px @bharat-c27

@bharat-c27
Copy link
Contributor Author

bharat-c27 commented Jul 13, 2024

@Rakesh9100 now the calculator is responsive for screen size less than 450px .

If there are no further modification can you assign me the issue #1317, I am done with the coding part. Only I have to raise the PR.

@Rakesh9100 Rakesh9100 merged commit 4ece784 into Rakesh9100:main Jul 14, 2024
4 checks passed
Copy link

Congrats, Your pull request has been successfully merged 🥳🎉 Thank you for your contribution to my project 🚀 Keep Contributing!! ✨ @bharat-c27

@Rakesh9100 Rakesh9100 added Completed 🥳 PR successfully merged and issue resolved on completion gssoc GSSoC 2k24 Open Source Program level3 GSSoC2k24 Level-3 Task -- 45 Points and removed question 🤔 Further information is requested labels Jul 14, 2024
@bharat-c27
Copy link
Contributor Author

@Rakesh9100 now the calculator is responsive for screen size less than 450px .

If there are no further modification can you assign me the issue #1317, I am done with the coding part. Only I have to raise the PR.

@Rakesh9100, can you please assign me the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completed 🥳 PR successfully merged and issue resolved on completion gssoc GSSoC 2k24 Open Source Program level3 GSSoC2k24 Level-3 Task -- 45 Points
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add Unique Prime Number Calculator
3 participants