Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a check for Realistic ages and height #1866

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

afreenpoly
Copy link

Fixes Issue🛠️

Closes #1368

Description👨‍💻

-Introduced a new function isValidCombination to validate the combination of age and height inputs. The function ensures that:

  1. For children (age 0-5), height is between 60 cm and 120 cm.
  2. For children (age 6-10), height is between 100 cm and 150 cm.
    3.For adults,No restriction

Type of Change📄

  • Bug fix (non-breaking change which fixes a bug)

Checklist✅

  • I am an Open Source contributor
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented on my code, particularly in hard-to-understand areas

Screenshots/GIF📷

Before

image

After

image

Copy link

netlify bot commented Aug 30, 2024

Deploy Preview for calcdiverse ready!

Name Link
🔨 Latest commit 900fbe8
🔍 Latest deploy log https://app.netlify.com/sites/calcdiverse/deploys/66d1848daf3c750008963d1e
😎 Deploy Preview https://deploy-preview-1866--calcdiverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @afreenpoly, Welcome to the project CalcDiverse! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] BMI calculator
1 participant