Modified Basic Calculator and Multiplication Table Calculator #577
Conversation
Basic Calculator: -> Refreshed with all new design -> Added Dark and Light Modes Multiplication Table Calculator: -> Some changes in the basic design of calculator -> All new way to display table without cropping the content -> Responsiveness added
✅ Deploy Preview for calcdiverse ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @Yuvraj960, Welcome to the project CalcDiverse! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨
|
Add the backspace button to clear a single digit, remove comma button in Basic Calculator. Place the code in index.html file only instead of main.html file @Yuvraj960 |
|
@Rakesh9100 removing the comma isn't possible as some functions like power(^) don't work without a comma. |
|
Ohkk, but we need a backspace button as well @Yuvraj960 |
More functions added to basic calculator -> Exponential function -> logarithmic function (natural log) -> Added CE button for erasing single letter from the display
Added screenshots of new UI of Calculator in the README file.
|
@Rakesh9100, please review the code again, necessary changes done in the calculator. |
|
Pls check the Log function as it is not giving the correct result. And previously, calculator was working with the keyboard numpad or buttons as well but I suppose you have deleted script.js file, so fix it!! |
|
@Rakesh9100, I didn't understand why you are not getting accurate results in log. Recording.2024-02-11.212125.mp4
And secondly I have removed the functionality of keypress events record because in browsers like firefox, every keypress on page is toggling the "find" feature. Here you can see the example: But if it the bug from my browser settings, please let me know. |
|
You have implemented ln(e) and has written log, which means log base 10 but calculating log base e. So prefer to change the calculation to base 10!! And about the keypress events, I have checked the previous calculator on chrome and Edge browsers where it is working fine as expected. So prefer keeping this functionality @Yuvraj960 |
Added the functionality of listening to the keypress events and appending values to display of the calculator
|
@Rakesh9100, added keypress event also, Please check for any other bug if there. Otherwise it is ready to be merged! |
|
Pls fix the log one as mentioned in above comment to base 10 instead of base e @Yuvraj960 |
Changed the base of Log function from 'e' (natural log) to 10.
|
Done @Rakesh9100 |
|
Should we proceed merging this PR? @Rakesh9100 |
|
Looks nice, Merged!! 🥳🎉 @Yuvraj960 |
Rakesh9100
added
Completed 🥳
Rakesh9100
changed the title
Fixes Issue🛠️
Closes #498
Description👨💻
Basic Calculator:
-> Refreshed with all new design
-> Added Dark and Light Modes
Multiplication Table Calculator:
-> Some changes in the basic design of calculator
-> All new way to display table without cropping the content -> Responsiveness added
Type of change📄
How this has been tested✅
Checklist✅
Screenshots/GIF📷