Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed multiple operators in Basic Calculator #906

Merged
merged 5 commits into from
May 31, 2024

Conversation

tanu-agarwal0101
Copy link
Contributor

@tanu-agarwal0101 tanu-agarwal0101 commented May 27, 2024

Fixes Issue🛠️

Closes #685

Description👨‍💻

Multiple operators issue fixed.

Type of change📄

  • Bug fix (non-breaking change which fixes an issue)

How this has been tested✅

Tested locally.

Checklist✅

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added demonstration in the form of GIF/video file
  • I am an Open Source Contributor

Screenshots/GIF📷

Before

image

Now

image

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tanu-agarwal0101, Welcome to the project CalcDiverse! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

Copy link

netlify bot commented May 27, 2024

Deploy Preview for calcdiverse ready!

Name Link
🔨 Latest commit 3283b1b
🔍 Latest deploy log https://app.netlify.com/sites/calcdiverse/deploys/66559c988240da00085ee1bc
😎 Deploy Preview https://deploy-preview-906--calcdiverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Rakesh9100 Rakesh9100 changed the title multiple operators issue resolved Fixed multiple operators in Basic Calculator May 27, 2024
@Rakesh9100
Copy link
Owner

The issue is solved from the UI part, but when we enter input from keyboard, the issue is not fixed. Pls see to this @tanu-agarwal0101

Make the new commits in this same PR, don't create a new PR!!

@Rakesh9100 Rakesh9100 added the question 🤔 Further information is requested label May 27, 2024
@tanu-agarwal0101
Copy link
Contributor Author

Ok sir

@tanu-agarwal0101
Copy link
Contributor Author

@Rakesh9100 please check now

@Rakesh9100 Rakesh9100 merged commit 0f82ee6 into Rakesh9100:main May 31, 2024
4 checks passed
@Rakesh9100
Copy link
Owner

Congrats on getting your PR merged to the repo under GSSOC 2k24 🥳🎉 @tanu-agarwal0101

@Rakesh9100 Rakesh9100 added Completed 🥳 PR successfully merged and issue resolved on completion gssoc GSSoC 2k24 Open Source Program level3 GSSoC2k24 Level-3 Task -- 45 Points and removed question 🤔 Further information is requested labels May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completed 🥳 PR successfully merged and issue resolved on completion gssoc GSSoC 2k24 Open Source Program level3 GSSoC2k24 Level-3 Task -- 45 Points
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Fix multiple operators in Basic Calculator
2 participants