Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable test file that hogs up all memory #864

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

usev6
Copy link
Contributor

@usev6 usev6 commented Oct 15, 2024

No description provided.

@coke
Copy link
Contributor

coke commented Oct 15, 2024

It's too stressful even for stress?

@dwarring
Copy link
Contributor

I getting this with Rakudo HEAD:

david@pc:~/git/roast$ raku -v
Welcome to Rakudo™ v2024.09-97-gb56ba4c58.
Implementing the Raku® Programming Language v6.d.
Built on MoarVM version 2024.09-5-g174aa1ba9.
david@pc:~/git/roast$ time raku integration/advent2012-day21.t 
1..9
ok 1 - main usage
Killed

real	0m11.446s
user	0m7.057s
sys	0m3.548s

Seems to eat up memory very quickly (32Gb)

Compared to 2024.09:

david@pc:~/git/roast$ raku -v
Welcome to Rakudo™ v2024.09.
Implementing the Raku® Programming Language v6.d.
Built on MoarVM version 2024.09.
david@pc:~/git/roast$ time raku integration/advent2012-day21.t 
1..9
ok 1 - main usage
ok 2 - sequence
ok 3 - recursive-ternary-hand-cached
ok 4 - sequence-ternary
ok 5 - loop
ok 6 - recursive-ternary
ok 7 - hand-memoization
ok 8 - gerdr
ok 9 - kaz
# recursive-ternary: 0.239854419 seconds
# loop: 0.240001791 seconds
# gerdr: 0.242101961 seconds
# kaz: 0.242638278 seconds
# hand-memoization: 0.249875383 seconds
# sequence-ternary: 0.305388659 seconds
# recursive-ternary-hand-cached: 0.339483588 seconds
# sequence: 0.423099127 seconds

real	0m3.012s
user	0m3.680s
sys	0m0.348s

Looks like a performance regression. Are others getting similar results?

@usev6
Copy link
Contributor Author

usev6 commented Oct 16, 2024

Oh, that's interesting. I know that the tests were fine for me in the past (like until a year ago), but I wasn't aware that it even worked with 2024.09.

So hopefully the problem can be identified and fixed (instead of disabling the test file permanently). Do you think it makes more sense to create an issue?

@lizmat
Copy link
Contributor

lizmat commented Oct 16, 2024

yes, please

@usev6
Copy link
Contributor Author

usev6 commented Oct 16, 2024

Ok, I've created an issue for Rakudo: rakudo/rakudo#5665

I'd still like to see the test file temporarily disabled. It's not so nice to cause critical memory shortages for people who run the tests.

@lizmat lizmat merged commit a9808b7 into Raku:master Oct 16, 2024
@usev6 usev6 deleted the disable_advent2012-day21 branch October 16, 2024 17:26
@usev6
Copy link
Contributor Author

usev6 commented Oct 16, 2024

Thanks. Hopefully we can bring the tests back soon.

@usev6
Copy link
Contributor Author

usev6 commented Oct 23, 2024

Just for the record: The test file is enabled again (9bf4b1e)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants