Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rocket Hideout #986

Draft
wants to merge 6 commits into
base: 9bit
Choose a base branch
from
Draft

Rocket Hideout #986

wants to merge 6 commits into from

Conversation

vulcandth
Copy link
Collaborator

@vulcandth vulcandth commented Dec 24, 2024

NOTICE: This causes a minor save break due to adding an additional key item and shifting a little bit of ram. Recommend if this gets merged it should be part of v3.1.0 or v3.2.0 for save patching... (Or we can get rid of the LIFT_KEY item)

Some Todos:

  • Replace RARE_CANDY placeholder items
  • Better Dialogue (some of its fine, a lot of its barely better than placeholder text)
  • Actually implement the CherryGroveBay events.
  • Review pickup items for alternate choices.
  • New names for NPCs; search for ; TODO: replace placeholder name
  • Fix Sparks Pikachu animation

@Rangi42
Copy link
Owner

Rangi42 commented Dec 28, 2024

@vulcandth @SoupPotato Thank you both so much for tackling this unfinished content! As I review/playtest it, I'll be making some notes here on what could be updated -- not necessarily by either of you, and not generally blockers for merging, just ideas.

  • The RBY hideout music could instead be a PGo remix of something. (I'm not sure what already exists, or who's still in the scene making new ones.)
  • The stairs should be hidden requiring a poster switch (and beating a grunt in front of it first, who would clue the player into the whole "PGo teams are hiding down here" thing). (Keep in mind how obviously telegraphed the RBY Rocket hideout was -- it's good design for ten-year-olds, and also for fast-forwarding players with the attention of ten-year-olds. :P )

data/trainers/parties.asm Outdated Show resolved Hide resolved
data/trainers/parties.asm Outdated Show resolved Hide resolved
data/trainers/parties.asm Outdated Show resolved Hide resolved
constants/trainer_constants.asm Outdated Show resolved Hide resolved
maps/RocketHideoutB1F.asm Outdated Show resolved Hide resolved
maps/RocketHideoutB1F.asm Outdated Show resolved Hide resolved
maps/RocketHideoutB1F.asm Outdated Show resolved Hide resolved
maps/RocketHideoutB1F.asm Outdated Show resolved Hide resolved
maps/RocketHideoutB2F.asm Outdated Show resolved Hide resolved
maps/RocketHideoutB3F.asm Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants