Skip to content

Commit

Permalink
Merge pull request #1111 from RasaHQ/ci/ATO-1652-check-for-proto-pyth…
Browse files Browse the repository at this point in the history
…on-discrepancy

[ATO-1652] Add target to check if gRPC code is in sync with generated python code
  • Loading branch information
radovanZRasa authored Jun 19, 2024
2 parents c69c9fe + 8b8ce99 commit 2247a58
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 1 deletion.
3 changes: 3 additions & 0 deletions .github/workflows/continuous-integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,9 @@ jobs:
- name: Install Dependencies 📦
run: make install

- name: Listing Dependencies 📦
run: poetry show

- name: Lint Code 🎎
run: |
# If it's not a pull request, $DOCSTRING_DIFF_BRANCH is unset.
Expand Down
12 changes: 11 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ install:
poetry run python -m pip install -U pip
poetry install

install-dev:
poetry run python -m pip install -U pip
poetry install --with dev

clean:
find . -name '*.pyc' -exec rm -f {} +
find . -name '*.pyo' -exec rm -f {} +
Expand All @@ -38,6 +42,7 @@ lint:
poetry run ruff check rasa_sdk tests --ignore D
poetry run black --exclude="rasa_sdk/grpc_py" --check rasa_sdk tests
make lint-docstrings
make check-generate-grpc-code-in-sync

# Compare against `main` if no branch was provided
BRANCH ?= main
Expand All @@ -62,10 +67,15 @@ release:
poetry run python scripts/release.py

generate-grpc:
python -m grpc_tools.protoc \
poetry run python -m grpc_tools.protoc \
-Irasa_sdk/grpc_py=./proto \
--python_out=. \
--grpc_python_out=. \
--pyi_out=. \
proto/action_webhook.proto \
proto/health.proto

check-generate-grpc-code-in-sync: generate-grpc
# this is a helper to check if the generated code is in sync with the proto files
# it's not run on CI at the moment
git diff --exit-code rasa_sdk/grpc_py | if [ "$$(wc -c)" -eq 0 ]; then echo "Generated code is in sync with proto files"; else echo "Generated code is not in sync with proto files"; exit 1; fi

0 comments on commit 2247a58

Please sign in to comment.