-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENG-1235: Push release tags automatically on rasa-sdk
#1139
ENG-1235: Push release tags automatically on rasa-sdk
#1139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job 🎉
Left two small comments and would be great if we could also test this before merge.
edit : I see you have tested this locally 🥇
- name: Checkout git repository 🕝 | ||
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4 | ||
with: | ||
token: ${{ secrets.RELEASE_TAGGER_PAT }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PAT token doesnot exist for the repo. @rasa-aadlv can you help with this please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RELEASE_TAGGER_PAT
now added to this repo's secrets (thanks @rasa-aadlv !)
scripts/release.py
Outdated
|
||
print_done_message(branch, base, version) | ||
if not version.pre: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not related to your changes but just noticed this was missing. Can you also add and not version.dev
here please? We shouldnt generate changelog for dev releases either.
rasa-sdk
rasa-sdk
Proposed changes:
Introduce mechanism to automatically create and push tag for release, similar to how it is already done in
rasa-private
. Summary of changes:scripts/release.py
to create and push release tag, if invoked with--tag
flag.Makefile
with new targetmake tag-release
.tag-release
, to do this in CI, when PR is merged tomain
or a release branch.Status (please check what you already did):
ruff
(please check Readme for instructions)*Ran
make release
andmake tag-release
locally, to see that a tag is created and pushed (Note: Tagging function checks that the branch ismain
or a final release branch (complying to regex pattern^\d+\.\d+\.x$
for e.g.1.2.x
), so locally disabled this check so that I can test on a dev-test release branch):