Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing spelling errors in rasa-sdk #833

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog/833.misc.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed some 8 spelling errors in rasa-sdk documentation and code.
2 changes: 1 addition & 1 deletion docs/docs/events.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,7 @@ Logs an action called by the bot. Only the action itself is logged; the events t

**Automatic Tracking**:

* Any action (including custom actions and responses) that is called, even if the action does not execute succesfully.
* Any action (including custom actions and responses) that is called, even if the action does not execute successfully.

This event is not usually returned explicitly by a custom action.

Expand Down
2 changes: 1 addition & 1 deletion docs/docs/validation-action.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ The method `required_slots` will return the `domain_slots` which is a list of al
##### FormValidationAction.next_requested_slot

The method `next_requested_slot` will set the value of `REQUESTED_SLOT` to the next unset slot only if the
`required_slots` method was overriden by the custom action subclassing `FormValidationAction`.
`required_slots` method was overridden by the custom action subclassing `FormValidationAction`.

If users didn't override `required_slots` then we'll let the `FormAction` within Rasa Open
Source request the next slot, and the method will return `None`.
Expand Down
2 changes: 1 addition & 1 deletion docs/plugins/included_source.js
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ async function getIncludedSources(options) {
contained in `versioned_docs/version-xxx/sources/...`. This is what this function
does.
Options:
- docsDir: the directory containing the versionned docs files
- docsDir: the directory containing the versioned docs files
- relativeSourceDir: the directory that will contain the included sources
- include: list of patterns to look for doc files
*/
Expand Down
2 changes: 1 addition & 1 deletion rasa_sdk/cli/arguments.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def add_endpoint_arguments(parser):
"--ssl-password",
default=None,
help="If your ssl-keyfile is protected by a password, you can specify it "
"using this paramer.",
"using this parameter.",
)
parser.add_argument(
"--auto-reload",
Expand Down
2 changes: 1 addition & 1 deletion rasa_sdk/interfaces.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def __init__(
@property
def active_form(self) -> Dict[Text, Any]:
warnings.warn(
Copy link
Member

@ancalita ancalita Sep 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linter check failed on line 71 because it expected a docstring, could you please add the following docstring:

Returns the active_loop dictionary.

"Use of `active_form` is deprecated. Please use `active_loop insteaad.",
"Use of `active_form` is deprecated. Please use `active_loop instead.",
DeprecationWarning,
)
return self.active_loop
Expand Down
2 changes: 1 addition & 1 deletion tests/test_forms.py
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ def validate_slot1(
)

assert not warnings
# validation shoudn't run because `TestSlotValidationAction` implements
# validation shouldn't run because `TestSlotValidationAction` implements
# `FormValidationAction` and `slot1` is not assigned to any form
assert events == []

Expand Down