-
-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internationalization (i18n) #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for internationalization (i18n) and localization (l12n) by using GNU's Gettext to manage multi-lingual messages in a standardized way. It's assumed that the user has configured a language package on the RPi corresponding to one of our supported translations.
To list languages currently installed on the system, use
$ locale -a
at the shell prompt. This should return a list like the one below:To generate new locales, run
$ sudo dpkg-reconfigure locales
and select any other desired locales. Important: UTF-8 is the preferred encoding.The new file
includes/locale.php
sets the user's current locale using a very simple method. At the moment French (fr_FR) is the only supported translation (it could almost certainly be improved 😉). The default is en_US. Alternatively, it could be set to en_GB as this locale is enabled by default on Raspbian. So far volunteers have offered to translate German, Italian and Spanish #121.The advantages of making RaspAP a multi-lingual project are obvious. The downside is the extra burden of maintenance going forward. Any future addition or change to a label in the UI will require localization into each of the supported languages. The good news is, this can be done by editing the Portable Object (.po) files centrally and recompiling the Machine Object (.mo) files.
Thoughts?
Resolves #122