Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: prevent duplicate array values in ParseConfig() #1432

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Fix: prevent duplicate array values in ParseConfig() #1432

merged 1 commit into from
Oct 27, 2023

Conversation

billz
Copy link
Member

@billz billz commented Oct 25, 2023

Ignored config entries (blank lines or "#" comments) result in a duplicate array values for preceding entries, eg.:

[DNS] => Array
    (
        [0] => 10.64.0.1
        [1] => 10.64.0.1
    )

Probably due to a change in PHP 8's internal array handling, as this was not observed in PHP 7.x.

@billz billz merged commit ce001ae into master Oct 27, 2023
3 checks passed
@billz billz deleted the fix/parse-config branch October 27, 2023 11:39
@billz billz mentioned this pull request May 12, 2024
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
confirmed bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@billz