included messages.properties file in app config #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good! It's better to have a complete way to do i18n stuff. I'll consider it later. Back to your commit, it seems the |
|
If you are open to collaboration and merging my code, I am interested to work on the i18n feature. Regarding my commit, I have tested the thymeleaf template pages reading the i18n/messages dir properly. |
|
Yes, you're welcome to contribute. Can you commit a simple example, including the message property files and usages in thymeleaf? So I can review them and see if it's ok to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need spring.messages.basename defined in app config so it can be accessed from the view templates.