Merge pull request #394 from Rblp/bugfix/bds

Correct request formation as identified in #393
Rblp · Sep 5, 2024 · 882e546 · 882e546
2 parents 9315eee + ec7c603
commit 882e546
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/bds.cpp b/src/bds.cpp
@@ -266,9 +266,9 @@ Rcpp::List bds_Impl(SEXP con_, std::vector<std::string> securities,
     Service refDataService = session->getService(rdsrv.c_str());
     Request request = refDataService.createRequest("ReferenceDataRequest");
     for (size_t i = 0; i < securities.size(); i++) {
-        request.getElement(Name{"securities"}).appendValue(Name{securities[i].c_str()});
+        request.getElement(Name{"securities"}).appendValue(securities[i].c_str());
     }
-    request.getElement(Name{"fields"}).appendValue(Name{field.c_str()});
+    request.getElement(Name{"fields"}).appendValue(field.c_str());
     appendOptionsToRequest(request,options_);
     appendOverridesToRequest(request,overrides_);
 
@@ -311,9 +311,9 @@ Rcpp::List getPortfolio_Impl(SEXP con_, std::vector<std::string> securities,
     Service refDataService = session->getService(rdsrv.c_str());
     Request request = refDataService.createRequest("PortfolioDataRequest");
     for (size_t i = 0; i < securities.size(); i++) {
-        request.getElement(Name{"securities"}).appendValue(Name{securities[i].c_str()});
+        request.getElement(Name{"securities"}).appendValue(securities[i].c_str());
     }
-    request.getElement(Name{"fields"}).appendValue(Name{field.c_str()});
+    request.getElement(Name{"fields"}).appendValue(field.c_str());
     appendOptionsToRequest(request,options_);
     appendOverridesToRequest(request,overrides_);