Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use release 3.24.6.1 #397

Merged
merged 8 commits into from
Sep 11, 2024
Merged

Use release 3.24.6.1 #397

merged 8 commits into from
Sep 11, 2024

Conversation

eddelbuettel
Copy link
Member

This PR switches to release 3.24.6.1 of the Bloomberg API, and enables arm64 builds for macOS.

We attempted to resurrect x86_64 builds for macOS. As the current release of the Bloomberg API supports only arm64 on macOS, we retain the previouse. And while that built fine previously it somehow now fails (at r-universe) for that platform. It may hence also fail at CRAN for macOS x86_64. We would need to rely on someone with that platform to debug more locally.

After approving please do not merge immediately but allow me to do so also in preparation of a next release.

@eddelbuettel eddelbuettel changed the title Feature/release 3.24.6.1 Use release 3.24.6.1 Sep 6, 2024
@johnlaing
Copy link
Contributor

Looks good from my end. I don't see the option to approve, if you'd like to request a review for good order I'll approve it, otherwise this comment can suffice.

@eddelbuettel
Copy link
Member Author

eddelbuettel commented Sep 10, 2024

Thanks! I now tagged you explicitly, maybe that makes a difference? Otherwise I find if one goes into 'Files changed' (the right-most menu in the bar under the title) it usually offers the selection. I.e. screenshot of the menu:

image

It should lead to

image

which (here, for me) only offers 'comment' as I cannot approve a PR I started. You should have the 'Approve' button and of course the edit field if you want to use it. And of course one can comment per-file and per-line as usual.

@eddelbuettel
Copy link
Member Author

I am going to make this a 'squash and merge'. We will see if this stick but linear and compact git histories are nice in some other repositories.

Once merged we can let this 'sit' for a bit, announce the new binaries available via r-universe and then release to CRAN in a few days now backed by two real tests already.

@eddelbuettel eddelbuettel merged commit a16d3fd into master Sep 11, 2024
4 checks passed
@eddelbuettel eddelbuettel deleted the feature/release_3.24.6.1 branch September 11, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants