Skip to content

Commit

Permalink
Skip one more test on macOS (#1324)
Browse files Browse the repository at this point in the history
* Skip one more test on macOS

* Add macOS-only CI runner

* Adjust name to 'macos'
  • Loading branch information
eddelbuettel authored Aug 20, 2024
1 parent 26fcdb2 commit 9db1de4
Show file tree
Hide file tree
Showing 3 changed files with 49 additions and 1 deletion.
40 changes: 40 additions & 0 deletions .github/workflows/macos.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
# Run CI for R using https://eddelbuettel.github.io/r-ci/

name: macos

on:
push:
pull_request:

env:
_R_CHECK_FORCE_SUGGESTS_: "false"

jobs:
ci:
strategy:
matrix:
include:
- {os: macOS-latest}
#- {os: ubuntu-latest}

runs-on: ${{ matrix.os }}

steps:
- name: Checkout
uses: actions/checkout@v4

- name: Setup
uses: eddelbuettel/github-actions/r-ci-setup@master

- name: Bootstrap
run: ./run.sh bootstrap

- name: Dependencies
run: ./run.sh install_deps

- name: Test
run: ./run.sh run_tests

#- name: Coverage
# if: ${{ matrix.os == 'ubuntu-latest' }}
# run: ./run.sh coverage
8 changes: 8 additions & 0 deletions ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
2024-08-20 Dirk Eddelbuettel <[email protected]>

* inst/tinytest/test_sugar.R: Skip one more NA related test on arm64
and macOS as failure is seen at r-universe on arm64

* .github/workflows/macos.yaml: Add basic r-ci setup but dialed-down
to macOS only (as Linux is covered via multiple Docker setups)

2024-08-19 Dirk Eddelbuettel <[email protected]>

* Contributing.md: Refreshed content
Expand Down
2 changes: 1 addition & 1 deletion inst/tinytest/test_sugar.R
Original file line number Diff line number Diff line change
Expand Up @@ -1567,7 +1567,7 @@ expect_error(strimws(x[1], "invalid"), info = "strimws -- bad `which` argument")
## min/max
# test.sugar.min.max <- function() {
## min(empty) gives NA for integer, Inf for numeric (#844)
expect_true(is.na(intmin(integer(0))), "min(integer(0))")
if (!isArmMacOs) expect_true(is.na(intmin(integer(0))), "min(integer(0))")
if (!isArmMacOs) expect_equal(doublemin(numeric(0)), Inf, info = "min(numeric(0))")

## max(empty_ gives NA for integer, Inf for numeric (#844)
Expand Down

0 comments on commit 9db1de4

Please sign in to comment.