Skip to content

Commit

Permalink
Add missing includes (#1272)
Browse files Browse the repository at this point in the history
* Add missing includes

* Update date.cpp

* Update ChangeLog

* Update PULL_REQUEST_TEMPLATE.md
  • Loading branch information
MichaelChirico authored Aug 3, 2023
1 parent 85d59f7 commit f46b724
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 1 deletion.
2 changes: 1 addition & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@ Please explain the changes you want to apply to Rcpp, preferably in an issue tic

- [ ] Code compiles correctly
- [ ] `R CMD check` still passes all tests
- [ ] Prefereably, new tests were added which fail without the change
- [ ] Preferably, new tests were added which fail without the change
- [ ] Document the changes by file in [ChangeLog](https://github.com/RcppCore/Rcpp/blob/master/ChangeLog)
5 changes: 5 additions & 0 deletions ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
2023-08-03 Michael Chirico <[email protected]>

* src/attributes.cpp: Directly `#include <ostream>` for `std::endl`
* src/date.cpp: Directly `#include <R_ext/Booelan.h>` for `TRUE` and `FALSE`

2023-07-03 Dirk Eddelbuettel <[email protected]>

* DESCRIPTION (Date, Version): Release 1.0.11
Expand Down
1 change: 1 addition & 0 deletions src/attributes.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
#include <map>
#include <set>
#include <algorithm>
#include <ostream> // for std::endl
#include <fstream>
#include <sstream>

Expand Down
1 change: 1 addition & 0 deletions src/date.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@

#define COMPILING_RCPP

#include <R_ext/Boolean.h> // for TRUE,FALSE
#include <Rcpp.h>
#include <time.h> // for gmtime
#include <Rcpp/exceptions.h>
Expand Down

0 comments on commit f46b724

Please sign in to comment.