Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing includes #1272

Merged
merged 4 commits into from
Aug 3, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@ Please explain the changes you want to apply to Rcpp, preferably in an issue tic

- [ ] Code compiles correctly
- [ ] `R CMD check` still passes all tests
- [ ] Prefereably, new tests were added which fail without the change
- [ ] Preferably, new tests were added which fail without the change
- [ ] Document the changes by file in [ChangeLog](https://github.com/RcppCore/Rcpp/blob/master/ChangeLog)
5 changes: 5 additions & 0 deletions ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
2023-08-03 Michael Chirico <[email protected]>

* src/attributes.cpp: Directly `#include <ostream>` for `std::endl`
* src/date.cpp: Directly `#include <R_ext/Booelan.h>` for `TRUE` and `FALSE`

2023-07-03 Dirk Eddelbuettel <[email protected]>

* DESCRIPTION (Date, Version): Release 1.0.11
Expand Down
1 change: 1 addition & 0 deletions src/attributes.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
#include <map>
#include <set>
#include <algorithm>
#include <ostream> // for std::endl
#include <fstream>
#include <sstream>

Expand Down
1 change: 1 addition & 0 deletions src/date.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@

#define COMPILING_RCPP

#include <R_ext/Boolean.h> // for TRUE,FALSE
#include <Rcpp.h>
#include <time.h> // for gmtime
#include <Rcpp/exceptions.h>
Expand Down