-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify %s should be TRUE or FALSE messages #6066
Comments
Should I also include this error message:
Taking a look at
Should I do a mass refactoring of all error messages with "TRUE or FALSE"? Some have "should be" and some have "must be", or should I just stick to the ones listed above? |
the 'fromLast' one can be included, the other two have subtle differences that mean they can't be easily collapsed. If you think they're identical (or close to it), feel free to include in a PR; worst case we'll just revert those during review. |
Out of curiosity, what's the advantage of having %s over putting the argument in the string? |
DRY principle for translation. different strings might wind up translated differently even though the English is the same. |
Originally posted by @MichaelChirico in #6044 (comment)
Currently:
The text was updated successfully, but these errors were encountered: