Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use %s in 'should be TRUE or FALSE' messages #6075

Merged
merged 5 commits into from
Apr 11, 2024
Merged

Use %s in 'should be TRUE or FALSE' messages #6075

merged 5 commits into from
Apr 11, 2024

Conversation

joshhwuu
Copy link
Member

Closes #6066

MichaelChirico
MichaelChirico reviewed Apr 11, 2024
View reviewed changes
R/duplicated.R Outdated Show resolved Hide resolved
MichaelChirico
MichaelChirico reviewed Apr 11, 2024
View reviewed changes
R/duplicated.R Outdated Show resolved Hide resolved
MichaelChirico
MichaelChirico reviewed Apr 11, 2024
View reviewed changes
src/rbindlist.c Outdated Show resolved Hide resolved
@MichaelChirico
Copy link
Member

Please add one more: src/nafill.c:103: error(_("nan_is_na must be TRUE or FALSE")); // # nocov

MichaelChirico
MichaelChirico approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@MichaelChirico MichaelChirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@MichaelChirico MichaelChirico merged commit 3171397 into master Apr 11, 2024
3 checks passed
@MichaelChirico MichaelChirico deleted the unifytfmsg branch April 11, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelChirico MichaelChirico MichaelChirico approved these changes

@jangorecki jangorecki Awaiting requested review from jangorecki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unify %s should be TRUE or FALSE messages
2 participants
@joshhwuu @MichaelChirico