-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
colnamesInt() has unfriendly behavior w.r.t. missing (NA) columns #6070
Comments
I believe making |
Please start from here -- can you write an example using only the public API that generates the above "bad" error message? |
Certainly, I'll begin by locating an example that triggers this message. However, what if the error cannot be replicated using the public API? Will we simply let it remain unresolved? |
Yes. We shouldn't waste time over-complicating an internal function that has edge case behavior no user can ever see (unless they "violate the contract" and access the private API). |
In fact I find the current behavior odd as well:
I think it's outside the scope of this PR though, I'll file a follow-up issue.
Originally posted by @MichaelChirico in #6068 (comment)
First, we should check that it's actually possible to provide NA to this column since it's a private function (maybe we fully control all inputs & know for sure it can't receive missing inputs).
If user might provide
NA
, we should handle this better.If
NA
input is impossible, we should drop tests with missing input.The text was updated successfully, but these errors were encountered: