Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added skip_absent arguement to colnamesInt() #6068

Merged
merged 29 commits into from
Apr 11, 2024
Merged

Added skip_absent arguement to colnamesInt() #6068

merged 29 commits into from
Apr 11, 2024

Conversation

Nj221102
Copy link
Contributor

@Nj221102 Nj221102 commented Apr 10, 2024 •
edited
Loading

  • Description:
    • Introduces a new skip_absent argument to the colnamesInt() function.
    • When set to TRUE, allows the function to continue execution without throwing an error when some columns specified in the cols argument are not found.
    • Enhances flexibility for users by enabling them to proceed with operations even if some columns are absent.
    • Improves usability and robustness of the function.
  • Affected Files: colnamesInt.R
    Closes New argument skip_absent= for colnamesInt() not to error when some columns are not found #6067

@Nj221102 Nj221102 changed the base branch from colnamesInt to master April 10, 2024 16:03
MichaelChirico
MichaelChirico reviewed Apr 10, 2024
View reviewed changes
NEWS.md Outdated Show resolved Hide resolved
MichaelChirico
MichaelChirico reviewed Apr 10, 2024
View reviewed changes
src/utils.c Outdated Show resolved Hide resolved
@Nj221102 Nj221102 requested a review from MichaelChirico April 10, 2024 17:07
MichaelChirico
MichaelChirico reviewed Apr 10, 2024
View reviewed changes
src/nafill.c Outdated Show resolved Hide resolved
MichaelChirico
MichaelChirico reviewed Apr 10, 2024
View reviewed changes
src/utils.c Outdated Show resolved Hide resolved
MichaelChirico
MichaelChirico reviewed Apr 10, 2024
View reviewed changes
src/utils.c Outdated Show resolved Hide resolved
MichaelChirico
MichaelChirico reviewed Apr 10, 2024
View reviewed changes
src/utils.c Outdated Show resolved Hide resolved
MichaelChirico
MichaelChirico reviewed Apr 10, 2024
View reviewed changes
src/utils.c Outdated Show resolved Hide resolved
MichaelChirico
MichaelChirico reviewed Apr 10, 2024
View reviewed changes
src/utils.c Outdated Show resolved Hide resolved
@MichaelChirico MichaelChirico mentioned this pull request Apr 10, 2024
Open
@MichaelChirico
Copy link
Member

Looks basically good, mainly style points to tidy up & we can merge. Thanks!

@MichaelChirico MichaelChirico mentioned this pull request Apr 10, 2024
Merged
Nj221102 and others added 2 commits April 11, 2024 09:17
@Nj221102 @MichaelChirico
Update src/nafill.c
d5d3e10 
Co-authored-by: Michael Chirico <[email protected]>
@Nj221102 @MichaelChirico
Update src/utils.c
fdb30c8 
Co-authored-by: Michael Chirico <[email protected]>
MichaelChirico
MichaelChirico reviewed Apr 11, 2024
View reviewed changes
src/utils.c Outdated Show resolved Hide resolved
MichaelChirico
MichaelChirico reviewed Apr 11, 2024
View reviewed changes
src/utils.c Outdated Show resolved Hide resolved
MichaelChirico
MichaelChirico reviewed Apr 11, 2024
View reviewed changes
src/utils.c Outdated Show resolved Hide resolved
@Nj221102 Nj221102 requested a review from MichaelChirico April 11, 2024 09:48
MichaelChirico
MichaelChirico reviewed Apr 11, 2024
View reviewed changes
src/utils.c Outdated Show resolved Hide resolved
MichaelChirico
MichaelChirico reviewed Apr 11, 2024
View reviewed changes
src/utils.c Outdated Show resolved Hide resolved
MichaelChirico
MichaelChirico reviewed Apr 11, 2024
View reviewed changes
src/utils.c Outdated Show resolved Hide resolved
MichaelChirico
MichaelChirico reviewed Apr 11, 2024
View reviewed changes
src/utils.c Outdated Show resolved Hide resolved
MichaelChirico
MichaelChirico reviewed Apr 11, 2024
View reviewed changes
src/utils.c Outdated Show resolved Hide resolved
MichaelChirico
MichaelChirico approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@MichaelChirico MichaelChirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience & efforts!

@MichaelChirico MichaelChirico merged commit 0711e40 into Rdatatable:master Apr 11, 2024
3 checks passed
@MichaelChirico
Copy link
Member

@Nj221102 please make branches in this repo instead of your fork, it makes life easier for everyone :)

@Nj221102 Nj221102 deleted the colnamesInt branch April 11, 2024 16:32
@tdhock tdhock mentioned this pull request Jun 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelChirico MichaelChirico MichaelChirico approved these changes

@HughParsonage HughParsonage Awaiting requested review from HughParsonage HughParsonage is a code owner

@jangorecki jangorecki Awaiting requested review from jangorecki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New argument skip_absent= for colnamesInt() not to error when some columns are not found
2 participants
@Nj221102 @MichaelChirico