This repository has been archived by the owner on Oct 26, 2024. It is now read-only.
perf(YouTube): Reduce memory requirement for prefix tree searching #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revanced-bot
pushed a commit
that referenced
this pull request
Oct 17, 2023
# [0.120.0-dev.4](v0.120.0-dev.3...v0.120.0-dev.4) (2023-10-17) ### Performance Improvements * **YouTube:** Reduce memory requirement for prefix tree searching ([#501](#501)) ([f5add51](f5add51))
revanced-bot
pushed a commit
that referenced
this pull request
Oct 20, 2023
# [0.120.0](v0.119.2...v0.120.0) (2023-10-20) ### Bug Fixes * **YouTube - Hide Layout components:** Exempt expandable chips from exceptions ([#498](#498)) ([6f79746](6f79746)) * **YouTube - Hide layout components:** Hide new channel watermark component ([9670bd3](9670bd3)) * **YouTube - Minimized playback:** Fix pip incorrectly showing if app is minimized immediately after opening a Short ([7d02774](7d02774)) * **YouTube - Old video quality menu:** Fix toast error on tablet devices ([#500](#500)) ([d3eba27](d3eba27)) ### Features * **YouTube - Theme:** Disable gradient loading screen ([fd09e46](fd09e46)) * **YouTube:** Add `Announcements` patch ([#503](#503)) ([59687f1](59687f1)) * **YouTube:** Add `Spoof device dimensions` patch ([16f1163](16f1163)) ### Performance Improvements * **YouTube:** Reduce memory requirement for prefix tree searching ([#501](#501)) ([f5add51](f5add51))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the prefix search to use a variable sized array which reduces memory usage.
Before this PR:
LithoFilterPatch: Using: 8 identifier filters (1 KB), 71 path filters (47 KB)This PR:
LithoFilterPatch: Using: 8 identifier filters (1 KB), 71 path filters (5 KB)Overall memory was already low. But the main benefit is less cpu cache churn, since it no longer loads cache lines that are mostly null.
On first startup it does require rehashing the node array as the filter patterns are added, but that takes 2 milliseconds total on a modern device (and that 2ms is only required once)
For reference, here is the rehashing the default litho filters go thru on app startup: