fix(ubuntu): specify all avd-related environment variables #410
+41
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow for users to modify android install directories via standard environment variables if desired by not clobbering env vars without checking first Define all the standard environment variables used in an emulator context
mikehardy
force-pushed
the
ubuntu-24-avd-env-vars
branch
from
3ca67ba
to
2d7a205
Compare
|
@ychescale9 I updated this PR to match current main and edited the description to justify why I think it is worthwhile |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This action does simply define all of the standard env vars per the android documentation https://developer.android.com/tools/variables#envar
Additionally, it forcibly overwrites those variables though there may be valid reasons that they exist already:
1- for self-hosted runners people may define the variables so the large AVD files are in a non-standard location
2- for ubuntu-24 with XDG_CONFIG_HOME set (vs ubuntu-22) one of the variables was already set, but to an unexpected location. You can either clobber it and install (which works) or you can take it and use it (which was also a valid workaround)
This PR attempts to respect the variables if they exist, but make sure they are all set + directories are created either way
Osoletes #405