Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the crash issue with objc_sync_enter lock when using Firebase. #2577

Closed
wants to merge 2 commits into from
Closed

Fix the crash issue with objc_sync_enter lock when using Firebase. #2577

wants to merge 2 commits into from

Conversation

pandaleecn
Copy link

@freak4pc freak4pc force-pushed the main branch 2 times, most recently from 1198683 to 5949cbd Compare April 21, 2024 07:09
Naveen-C-Ramachandrappa
Naveen-C-Ramachandrappa approved these changes Jul 16, 2024
View reviewed changes
Copy link

@Naveen-C-Ramachandrappa Naveen-C-Ramachandrappa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this crash. Looks good.

@freak4pc
Copy link
Member

freak4pc commented Oct 4, 2024

This PR looks quite dangerous IMO and I am not seeing a reasonable explanation it's needed. With no response from the original author, I'm closing this for now.

@freak4pc freak4pc closed this Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freak4pc freak4pc freak4pc left review comments

@Naveen-C-Ramachandrappa Naveen-C-Ramachandrappa Naveen-C-Ramachandrappa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pandaleecn @freak4pc @Naveen-C-Ramachandrappa