Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(types): typos #7503

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

docs(types): typos #7503

wants to merge 1 commit into from

Conversation

lor3k
Copy link

@lor3k lor3k commented Sep 29, 2024

Description:
Typos in docs

BREAKING CHANGE:

Related issue (if exists):

Copy link

nx-cloud bot commented Oct 2, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 52ca3c8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx compile rxjs

Sent with 💌 from NxCloud.

Copy link
Member

@jakovljevic-mladen jakovljevic-mladen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It looks like we have some issues with pipelines, so we can't merge this until they are resolved.

Thanks for the fix 🎉

@JamesHenry
Copy link
Contributor

JamesHenry commented Oct 29, 2024

Not only is there the type error on the latest TS workflow, in the latest Node v20 (20.18.0) there is now a failing unit test.

I debugged and fixed both the tests and TS compilations here it is ready for review: #7512

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants