refactor: add message in constant responses

Real-Dev-Squad · May 5, 2024 · cad3f65 · cad3f65
1 parent 46ad626
commit cad3f65
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/constants/responses.ts b/src/constants/responses.ts
@@ -77,3 +77,5 @@ export const INVALID_TOKEN_FORMAT =
   "Invalid Authentication header format. Expected 'Bearer <token>'";
 
 export const AUTHENTICATION_ERROR = "Invalid Authentication token";
+export const TASK_UPDATE_SENT_MESSAGE =
+  "Task update sent on Discord's tracking-updates channel.";
diff --git a/src/controllers/taskUpdatesHandler.ts b/src/controllers/taskUpdatesHandler.ts
@@ -25,9 +25,7 @@ export const sendTaskUpdatesHandler = async (request: IRequest, env: env) => {
       taskTitle,
       env
     );
-    return new JSONResponse(
-      "Task update sent on Discord's tracking-updates channel."
-    );
+    return new JSONResponse(response.TASK_UPDATE_SENT_MESSAGE);
   } catch (error: any) {
     return new JSONResponse({
       res: response.INTERNAL_SERVER_ERROR,

diff --git a/tests/unit/handlers/taskUpdateHandler.test.ts b/tests/unit/handlers/taskUpdateHandler.test.ts
@@ -67,6 +67,6 @@ describe("sendTaskUpdatesHandler", () => {
     );
     expect(result.status).toBe(200);
     const res: JSONResponse = await result.json();
-    expect(res).toBe("Task update sent on Discord's tracking-updates channel.");
+    expect(res).toBe(response.TASK_UPDATE_SENT_MESSAGE);
   });
 });