fix: change api name to /roles/:roleId

Real-Dev-Squad · Nov 8, 2024 · f2cabae · f2cabae
1 parent 5cc429d
commit f2cabae
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/src/index.ts b/src/index.ts
@@ -35,7 +35,7 @@ router.get("/", async () => {
 
 router.patch("/guild/member", changeNickname);
 
-router.delete("/guildroles/:roleId", deleteGuildRoleHandler);
+router.delete("/roles/:roleId", deleteGuildRoleHandler);
 
 router.put("/roles/create", createGuildRoleHandler);
 

diff --git a/tests/unit/handlers/deleteGuildRoleHandler.test.ts b/tests/unit/handlers/deleteGuildRoleHandler.test.ts
@@ -14,7 +14,7 @@ describe("deleteGuildRoleHandler", () => {
   const roleId = "1A32BEX04";
   it("should return NOT_FOUND when dev is false", async () => {
     const mockRequest = generateDummyRequestObject({
-      url: "/guildroles",
+      url: "/roles",
       params: {
         roleId: roleId,
       },
@@ -29,7 +29,7 @@ describe("deleteGuildRoleHandler", () => {
   });
   it("should return BAD_REQUEST when roleId is not valid", async () => {
     const mockRequest = generateDummyRequestObject({
-      url: "/guildroles",
+      url: "/roles",
       params: {
         roleId: "",
       },
@@ -45,7 +45,7 @@ describe("deleteGuildRoleHandler", () => {
   });
   it("should return BAD_SIGNATURE when authorization header is not provided", async () => {
     const mockRequest = generateDummyRequestObject({
-      url: "/guildroles",
+      url: "/roles",
       params: {
         roleId: roleId,
       },
@@ -61,7 +61,7 @@ describe("deleteGuildRoleHandler", () => {
   it("should return INTERNAL_SERVER_ERROR when response is not ok", async () => {
     const mockResponse = responseConstants.INTERNAL_SERVER_ERROR;
     const mockRequest = generateDummyRequestObject({
-      url: "/guildroles",
+      url: "/roles",
       params: {
         roleId: roleId,
       },
@@ -81,7 +81,7 @@ describe("deleteGuildRoleHandler", () => {
   it("should return INTERNAL_SERVER_ERROR when token is not verified", async () => {
     const mockResponse = responseConstants.INTERNAL_SERVER_ERROR;
     const mockRequest = generateDummyRequestObject({
-      url: "/guildroles",
+      url: "/roles",
       method: "DELETE",
       params: {
         roleId: roleId,
@@ -103,7 +103,7 @@ describe("deleteGuildRoleHandler", () => {
       status: 204,
     });
     const mockRequest = generateDummyRequestObject({
-      url: "/guildroles",
+      url: "/roles",
       method: "DELETE",
       params: {
         roleId: roleId,