Feat : Updated mention each flow #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joyguptaa
force-pushed
the
feat/mention-each-modification
branch
from
cd8d8a6 to
49ee62c
Compare
joyguptaa
force-pushed
the
feat/mention-each-modification
branch
from
dfeb245 to
46c8021
Compare
joyguptaa
commented
Mar 9, 2024
prakashchoudhary07
approved these changes
Mar 19, 2024
iamitprakash
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 8 March 2024
Developer Name: Joy Gupta
Issue Ticket Number
Description
This PR contains updated mention-each functionality. And also updated a field in some of the existing test cases.
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Note
In the images/video below you will see that is says found 3 users but then end up tagging so many users. This is because I am multiplying the matched users to test it out.
Screenshots
The numbers before each message are just for showing purpose. I've removed that in the PR.
For failing use case
Screen.Recording.2024-03-09.at.11.30.53.AM.mov
1screen-recording-2024-03-09-at-113302-am_WpCMLEYO.mov
Tested it for 300 Users
Test Coverage
For guild.ts
For mentionEach.ts