Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/remove tagged users #218

Merged
merged 8 commits into from
Apr 15, 2024
Merged

feat/remove tagged users #218

merged 8 commits into from
Apr 15, 2024

Conversation

rishirishhh
Copy link
Member

@rishirishhh rishirishhh commented Apr 11, 2024 •
edited
Loading

Date: 11 04 2024

Developer Name: Kavya Rishi

Issue Ticket Number

Removing users who satisfy certain conditions #229

Description

There are certain users whose tasks go red as they have not completed the task in time or there are certain users who are tagged group-idle-7d+ . These users need to be removed from the discord server as they do not comply to the rules. Currently this task is done manually which needs to be done via a discord command
Users will be removed whenever they will match this condition

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Screenshot from 2024-04-14 14-41-00

Test Coverage

image

Screenshot from 2024-04-14 14-41-00

Screenshot from 2024-04-11 12-27-11

Additional Notes

@rishirishhh rishirishhh requested a review from joyguptaa April 11, 2024 07:06
iamitprakash
iamitprakash requested changes Apr 11, 2024
View reviewed changes
src/constants/commands.ts Outdated Show resolved Hide resolved
src/constants/commands.ts Outdated Show resolved Hide resolved
src/controllers/kickEachUser.ts Outdated Show resolved Hide resolved
src/controllers/kickEachUser.ts Outdated Show resolved Hide resolved
sahsisunny
sahsisunny reviewed Apr 14, 2024
View reviewed changes
src/utils/removeUsers.ts
} from "./batchDiscordRequests";

export async function removeUsers(env: env, usersWithMatchingRole: string[]) {
const batchSize = 4;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think is should be in constants.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is in constant

@sahsisunny
Copy link
Contributor

Description

There are certain users whose tasks go red as they have not completed the task in time or there are certain users who are tagged group-idle-7d+ . These users need to be removed from the discord server as they do not comply to the rules. Currently this task is done manually which needs to be done via a discord command Users will be removed whenever they will match this condition

This command removes the users who have specific roles right?

@rishirishhh
Copy link
Member Author

rishirishhh commented Apr 14, 2024 •
edited
Loading

Description

There are certain users whose tasks go red as they have not completed the task in time or there are certain users who are tagged group-idle-7d+ . These users need to be removed from the discord server as they do not comply to the rules. Currently this task is done manually which needs to be done via a discord command Users will be removed whenever they will match this condition

This command removes the users who have specific roles right?

Yes this command removes the users with specific roles @sahsisunny

sahsisunny
sahsisunny previously approved these changes Apr 14, 2024
View reviewed changes
Copy link
Contributor

@sahsisunny sahsisunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

@rishirishhh
Copy link
Member Author

Screenshot from 2024-04-14 14-41-00
@ardourApeX
this the updated result

@rishirishhh rishirishhh changed the title Feat/remove tagged users feat/remove tagged users Apr 14, 2024
@iamitprakash iamitprakash merged commit ac2507c into Real-Dev-Squad:develop Apr 15, 2024
2 checks passed
@rishirishhh rishirishhh mentioned this pull request Apr 18, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sahsisunny sahsisunny sahsisunny approved these changes

@joyguptaa joyguptaa joyguptaa approved these changes

@iamitprakash iamitprakash iamitprakash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rishirishhh @sahsisunny @iamitprakash @joyguptaa