Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Implement Filter for Online Users in Tracking-Updates Channel Bot #220

Merged
merged 5 commits into from
Apr 17, 2024

Conversation

sahsisunny
Copy link
Contributor

@sahsisunny sahsisunny commented Apr 13, 2024

Date: 13 Apr 2024
Developer Name: @sahsisunny


Issue Ticket Number

Description

Implemented a filter in the tracking-updates channel bot to target only users with red tasks who are currently active on the server.

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Screenshot 1

image

Test Coverage

Screenshot 1

--------------------------------------|---------|----------|---------|---------|------------------------------------------------

File % Stmts % Branch % Funcs % Lines Uncovered Line #s
All files 91.77 85.38 92.68 91.63
config 100 100 100 100
config.ts 100 100 100 100
src/constants 100 100 100 100
commands.ts 100 100 100 100
inviteOptions.ts 100 100 100 100
nicknameAffixes.ts 100 100 100 100
requestsActions.ts 100 100 100 100
responses.ts 100 100 100 100
urls.ts 100 100 100 100
variables.ts 100 100 100 100
src/controllers 75.15 78.12 78.57 75.15
commandNotFound.ts 100 100 100 100
generateDiscordInvite.ts 93.33 100 100 93.33 22
guildRoleHandler.ts 66.05 71.42 66.66 66.05 26-37,41-53,68,100,106,134-138,154-155,160-177
helloCommand.ts 100 100 100 100
mentionEachUser.ts 88.23 83.33 100 88.23 46-54
verifyCommand.ts 100 100 100 100
src/utils 95.77 87.2 98.43 95.78
JsonResponse.ts 100 100 100 100
batchDiscordRequests.ts 95.52 94.11 100 96.82 130-131
checkDisplayType.ts 100 100 100 100
createDiscordHeaders.ts 100 100 100 100
createTaggableDiscordIds.ts 100 100 100 100
discordEphemeralResponse.ts 100 100 100 100
discordResponse.ts 100 100 100 100
extractDiscordIds.ts 100 100 100 100
fetchRdsData.ts 100 90.9 100 100 23
fetchTasks.ts 91.66 0 100 91.66 11
filterUsersByRole.ts 100 100 100 100
formatOOOMessage.ts 100 100 100 100
formatStatusToTitleCase.ts 100 100 100 100
formatTask.ts 100 100 100 100
formatUserDetails.ts 100 100 100 100
generateDiscordInvite.ts 79.16 33.33 100 79.16 43,47,51,55,61
getCommandName.ts 100 100 100 100
getDiscordIds.ts 100 100 100 100
getGuildMemberDetails.ts 100 100 100 100
getMembersInServer.ts 88.88 100 100 87.5 17
getUserDetails.ts 100 100 100 100
getUserOOODetails.ts 100 100 100 100
guildRole.ts 94.52 76.92 100 94.28 49-52,75-78
lowerCaseMessageCommand.ts 100 100 100 100
removeListening.ts 100 100 100 100
sendProfileServiceBlockedMessage.ts 100 100 100 100
sendUserDiscordData.ts 91.66 100 100 90.9 44
sleep.ts 100 100 100 100
taskOverDueDiscordMembers.ts 100 100 100 100
timeUtils.ts 100 100 100 100
updateNickname.ts 100 100 100 100
verifyAuthToken.ts 82.6 80 75 82.6 10,52-55
tests/fixtures 100 90 33.33 100
config.ts 100 100 100 100
fixture.ts 100 90 33.33 100 134
tasks.ts 100 100 100 100
user.ts 100 100 100 100
-------------------------------------- --------- ---------- --------- --------- ------------------------------------------------

Test Suites: 34 passed, 34 total
Tests: 144 passed, 144 total
Snapshots: 0 total
Time: 8.741 s
Ran all test suites.
'✅ All tests passed'

Additional Notes

…n: 'npm run lint-fix' for linting and 'npm run format-fix' for formatting, ensuring consistent code style across the project.
@sahsisunny sahsisunny marked this pull request as ready for review April 13, 2024 02:26
rishirishhh
rishirishhh previously approved these changes Apr 13, 2024
@sahsisunny sahsisunny requested a review from iamitprakash April 14, 2024 07:05
@sahsisunny
Copy link
Contributor Author

image

@iamitprakash iamitprakash merged commit bdef426 into develop Apr 17, 2024
2 checks passed
@iamitprakash iamitprakash deleted the issue-219-online-users-filter branch April 17, 2024 08:25
@sahsisunny sahsisunny mentioned this pull request Apr 17, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants