Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix/mention each order #231

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Conversation

joyguptaa
Copy link
Contributor

Date: 8 Aug 2024

Developer Name: @joyguptaa


Issue Ticket Number

Description

This PR contains a fix that will add a delay before it starts tagging users

Documentation Updated?

  • Yes
  • No, not needed

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Just for testing purpose, I am duplicating users. In actual those are 3 users only.

Screen.Recording.2024-08-08.at.8.32.42.AM.mov

Test Coverage

Screenshot 2024-08-08 at 9 41 37 AM

Additional Notes

iamitprakash and others added 2 commits May 6, 2024 19:52
Desc : As there is no other way to add a delay in callbacks provided to ctx.waitUntil, faking a promise is the only way left
@iamitprakash iamitprakash merged commit db8d2ea into develop Aug 8, 2024
2 checks passed
@iamitprakash iamitprakash deleted the bugFix/mention-each-order branch August 8, 2024 18:56
@joyguptaa joyguptaa restored the bugFix/mention-each-order branch August 17, 2024 14:26
iamitprakash added a commit that referenced this pull request Aug 17, 2024
Desc : As there is no other way to add a delay in callbacks provided to ctx.waitUntil, faking a promise is the only way left

Co-authored-by: Amit Prakash <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants